[rt #69243] simplify XS for i_tags_find() and i_tags_findn()

Use SysRet for return values, and use XSRETURN_UNDEF for the undef case

diff --git a/Imager.xs b/Imager.xs
index a4ab76157b79db2eea901c875cccfafec1884973..e4debb47c6d3cabb4b1a2be04c6672be575295e6 100644 (file)
--- a/Imager.xs
+++ b/Imager.xs
@@ -3676,7 +3676,7 @@ i_tags_add(im, name_sv, code, data_sv, idata)
       OUTPUT:
         RETVAL
 
       OUTPUT:
         RETVAL
 

-SV *
+SysRet

 i_tags_find(im, name, start)
         Imager::ImgRaw  im
         char *name
 i_tags_find(im, name, start)
         Imager::ImgRaw  im
         char *name


@@ -3685,17 +3685,14 @@ i_tags_find(im, name, start)
         int entry;
       CODE:
         if (i_tags_find(&im->tags, name, start, &entry)) {
         int entry;
       CODE:
         if (i_tags_find(&im->tags, name, start, &entry)) {

-          if (entry == 0)
-            RETVAL = newSVpv("0 but true", 0);
-          else
-            RETVAL = newSViv(entry);
+         RETVAL = entry;

         } else {
         } else {

-          RETVAL = &PL_sv_undef;
+          XSRETURN_UNDEF;

         }
       OUTPUT:
         RETVAL
 
         }
       OUTPUT:
         RETVAL
 

-SV *
+SysRet

 i_tags_findn(im, code, start)
         Imager::ImgRaw  im
         int             code
 i_tags_findn(im, code, start)
         Imager::ImgRaw  im
         int             code


@@ -3704,13 +3701,10 @@ i_tags_findn(im, code, start)
         int entry;
       CODE:
         if (i_tags_findn(&im->tags, code, start, &entry)) {
         int entry;
       CODE:
         if (i_tags_findn(&im->tags, code, start, &entry)) {

-          if (entry == 0)
-            RETVAL = newSVpv("0 but true", 0);
-          else
-            RETVAL = newSViv(entry);
+          RETVAL = entry;

         }
         else {
         }
         else {

-          RETVAL = &PL_sv_undef;
+          XSRETURN_UNDEF;

         }
       OUTPUT:
         RETVAL
         }
       OUTPUT:
         RETVAL