[rt #69243] use names for i_tags_add() instead of ST(n) and handle magic

The code checked SvOK() without SvGETMAGIC()

diff --git a/Imager.xs b/Imager.xs
index 3dc6d0b25c39e2a20824216027c1316f8ac7e749..a4ab76157b79db2eea901c875cccfafec1884973 100644 (file)
--- a/Imager.xs
+++ b/Imager.xs
@@ -3649,21 +3649,25 @@ i_tags_addn(im, name_sv, code, idata)
         RETVAL
 
 undef_int
         RETVAL
 
 undef_int

-i_tags_add(im, name, code, data, idata)
+i_tags_add(im, name_sv, code, data_sv, idata)

         Imager::ImgRaw  im
         Imager::ImgRaw  im

+       SV *name_sv

         int code
         int code

+       SV *data_sv

         int idata
       PREINIT:
         char *name;
         char *data;
         STRLEN len;
       CODE:
         int idata
       PREINIT:
         char *name;
         char *data;
         STRLEN len;
       CODE:

-        if (SvOK(ST(1)))
-          name = SvPV(ST(1), len);
+        SvGETMAGIC(name_sv);
+        if (SvOK(name_sv))
+          name = SvPV_nomg(name_sv, len);

         else
           name = NULL;
         else
           name = NULL;

-        if (SvOK(ST(3)))
-          data = SvPV(ST(3), len);
+       SvGETMAGIC(data_sv);
+        if (SvOK(data_sv))
+          data = SvPV(data_sv, len);

         else {
           data = NULL;
           len = 0;
         else {
           data = NULL;
           len = 0;