- fixed an inverted condition checking the giflib version, and

  replaced a manual test skip in t/t105gif.t

diff --git a/Changes b/Changes
index a773e3ab18917d8436ed83847ff48ec73449f81e..1a69720af301988a9cb2e64b98ba6756d76bc514 100644 (file)
--- a/Changes
+++ b/Changes
@@ -1100,6 +1100,8 @@ Revision history for Perl extension Imager.
 - prevent warnings from Makefile.PL when there's no libraries found
 - Imager no longer assumes that MSVC is the only native Win32 
   compiler, MinGW can be used to build Imager.
+- fixed an inverted condition checking the giflib version, and 
+  replaced a manual test skip in t/t105gif.t
 
 =================================================================
 

diff --git a/t/t105gif.t b/t/t105gif.t
index 3d910480652965893ccac6ab3c32e2bd45c94dc5..0f6971c510a9e287ea23fc1bddecc129fe69ff53 100644 (file)
--- a/t/t105gif.t
+++ b/t/t105gif.t
@@ -102,7 +102,7 @@ SKIP:
     my $gifver = Imager::i_giflib_version();
   SKIP:
     {
-      skip("giflib3 doesn't support callbacks", 4) if $gifver >= 4.0;
+      skip("giflib3 doesn't support callbacks", 4) unless $gifver >= 4.0;
       # reading with a callback
       # various sizes to make sure the buffering works
       # requested size
@@ -168,7 +168,9 @@ SKIP:
 
     my $can_write_callback = 0;
     unlink $buggy_giflib_file;
-    if ($gifver >= 4.0) {
+    SKIP:
+    {
+      skip("giflib3 doesn't support callbacks", 1) unless $gifver >= 4.0;
       ++$can_write_callback;
       my $good = ext_test(14, <<'ENDOFCODE');
 use Imager;
@@ -227,9 +229,6 @@ giflib was present.
 EOS
       }
     }
-    else {
-      print "ok 14 # skip giflib3 doesn't support callbacks\n";
-    }
     @imgs = ();
     my $c = i_color_new(0,0,0,0);
     for my $g (0..3) {