From 8b297a7a45ce91d3b34d27fba94ba0c99c3a6777 Mon Sep 17 00:00:00 2001 From: Tony Cook Date: Tue, 17 May 2005 02:02:25 +0000 Subject: [PATCH] - fixed an inverted condition checking the giflib version, and replaced a manual test skip in t/t105gif.t --- Changes | 2 ++ t/t105gif.t | 9 ++++----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/Changes b/Changes index a773e3ab..1a69720a 100644 --- a/Changes +++ b/Changes @@ -1100,6 +1100,8 @@ Revision history for Perl extension Imager. - prevent warnings from Makefile.PL when there's no libraries found - Imager no longer assumes that MSVC is the only native Win32 compiler, MinGW can be used to build Imager. +- fixed an inverted condition checking the giflib version, and + replaced a manual test skip in t/t105gif.t ================================================================= diff --git a/t/t105gif.t b/t/t105gif.t index 3d910480..0f6971c5 100644 --- a/t/t105gif.t +++ b/t/t105gif.t @@ -102,7 +102,7 @@ SKIP: my $gifver = Imager::i_giflib_version(); SKIP: { - skip("giflib3 doesn't support callbacks", 4) if $gifver >= 4.0; + skip("giflib3 doesn't support callbacks", 4) unless $gifver >= 4.0; # reading with a callback # various sizes to make sure the buffering works # requested size @@ -168,7 +168,9 @@ SKIP: my $can_write_callback = 0; unlink $buggy_giflib_file; - if ($gifver >= 4.0) { + SKIP: + { + skip("giflib3 doesn't support callbacks", 1) unless $gifver >= 4.0; ++$can_write_callback; my $good = ext_test(14, <<'ENDOFCODE'); use Imager; @@ -227,9 +229,6 @@ giflib was present. EOS } } - else { - print "ok 14 # skip giflib3 doesn't support callbacks\n"; - } @imgs = (); my $c = i_color_new(0,0,0,0); for my $g (0..3) { -- 2.39.5