[rt #69243] greatly simplify XS for i_gpixf()
authorTony Cook <tony@develop-help.com>
Fri, 24 May 2013 13:02:35 +0000 (23:02 +1000)
committerTony Cook <tony@develop-help.com>
Fri, 24 May 2013 13:02:35 +0000 (23:02 +1000)
Imager.xs

index 35dbd3e4ac96b548bd7e5c70f46392756888c783..53e91852d34fffada6ee37f4fb670e9f6bd21839 100644 (file)
--- a/Imager.xs
+++ b/Imager.xs
@@ -3525,22 +3525,16 @@ i_plinf(im, l, y, ...)
       OUTPUT:
         RETVAL
 
-SV *
+Imager::Color::Float
 i_gpixf(im, x, y)
        Imager::ImgRaw im
        i_img_dim x
        i_img_dim y;
-      PREINIT:
-        i_fcolor *color;
       CODE:
-       color = (i_fcolor *)mymalloc(sizeof(i_fcolor));
-       if (i_gpixf(im, x, y, color) == 0) {
-          RETVAL = NEWSV(0,0);
-          sv_setref_pv(RETVAL, "Imager::Color::Float", (void *)color);
-        }
-        else {
-          myfree(color);
-          RETVAL = &PL_sv_undef;
+       RETVAL = (i_fcolor *)mymalloc(sizeof(i_fcolor));
+       if (i_gpixf(im, x, y, RETVAL) != 0) {
+          myfree(RETVAL);
+          XSRETURN_UNDEF;
         }
       OUTPUT:
         RETVAL