- added samp-form.cgi and samp-image.cgi to the samples directory to

  demonstrate displaying a generated image on a HTML page.

diff --git a/Changes b/Changes
index 9ecca2128c6e27ac30811f0771a3145d0cffd18c..0088540d0b9efc4c3f37af53c26e80f1be3f00d1 100644 (file)
--- a/Changes
+++ b/Changes
@@ -1042,6 +1042,8 @@ Revision history for Perl extension Imager.
   values across to the returned color objects.
   http://rt.cpan.org/NoAuth/Bug.html?id=11860 
 - Imager::Cookbook wasn't included in the MANIFEST
+- added samp-form.cgi and samp-image.cgi to the samples directory to 
+  demonstrate displaying a generated image on a HTML page.
 
 =================================================================
 

diff --git a/MANIFEST b/MANIFEST
index c8afe450e17cf764eb8032ff90675e2dc165d35d..7c7dc827cacfccd03141704c819e5cc926f320bd 100644 (file)
--- a/MANIFEST
+++ b/MANIFEST
@@ -105,6 +105,8 @@ rotate.c
 samples/README
 samples/anaglyph.pl
 samples/interleave.pl
+samples/samp-form.cgi
+samples/samp-image.cgi
 spot.perl      For making an ordered dither matrix from a spot function
 stackmach.c
 stackmach.h

diff --git a/TODO b/TODO
index 9fcd5d57f702abe5542fd73ffb78ff29c6b5afb0..490f3e94e4b7bf6ff322fe7292d63868f17dabae 100644 (file)
--- a/TODO
+++ b/TODO
@@ -28,7 +28,7 @@ not commitments.
 - add concept index to Imager.pm pod (done, still working it)
 - replace testimg/penguin-base.ppm with a smaller image (done)
 - add a sample CGI HTML and image generation scripts that work together,
-  with appropriate security management
+  with appropriate security management (done)
 - add sample CGI that handles an uploaded image
 - examples for fountain filter in Imager::Filters
 - provide access to right-side bearing information from the bounding box
@@ -46,6 +46,13 @@ not commitments.
 - implement gsamp()/gsampf()/plin() etc methods for those low level image
   interfaces which don't yet have methods.
 - implement i_incomplete for png and gif files.
+- documentation audit, check:
+  - every method has at least one example, but if the method is complex
+    (like transform2, to_paletted, string() for example) it should include 
+    a range of examples
+  - check each method description to ensure it's reasonably clear.
+  - check POD sections (SEE ALSO in particular)
+- rework handling of antialiasing against transparent images
 
 Speculation
 -----------

diff --git a/lib/Imager/Cookbook.pod b/lib/Imager/Cookbook.pod
index e909487431f8bdc4319e6cb82828938b6073977b..b82f6970c647ce824d55d6961851e9d7854ff85f 100644 (file)
--- a/lib/Imager/Cookbook.pod
+++ b/lib/Imager/Cookbook.pod
@@ -156,6 +156,10 @@ the values supplied to both requests.
 How you make the data available to the image generation code depends
 on your application.
 
+See C<samples/samp-form.cgi> and C<samples/samp-image.cgi> in the
+Imager distribution for one approach.  The POD in C<samp-form.cgi>
+also discusses some of the issues involved.
+
 =head2 Parsing an image posted via CGI
 
 C<WARNING>: file format attacks have become a common attack vector,

diff --git a/samples/README b/samples/README
index deaa278d9fa9dca39a1dbe9209329e500be7b9f5..959d2e3bc5fc6f9217ad391ab6d83c5665e84bdb 100644 (file)
--- a/samples/README
+++ b/samples/README
@@ -20,3 +20,11 @@ interleave.pl
   This includes 3 different implementations, first using transform2(),
   the second using the internal i_copyto() function and the third using
   the internal i_glin() and i_plin() functions.
+
+samp-form.cgi
+samp-image.cgi
+
+  Example that demonstrates generating an image linked from a HTML form.
+
+  The POD for this sample discusses alternate approaches and security
+  considerations.