- extra tests to distinguish errno problems from P::X::Q:A bugs,

   possibly leading to a workaround
   https://rt.cpan.org/Ticket/Display.html?id=35044

diff --git a/Array.xs b/Array.xs
index 338f8283d4cb3d4b3c889f959d013e60c4b30d9f..6d515aad98e11aa35a44226734beedf5d18db2a2 100644 (file)
--- a/Array.xs
+++ b/Array.xs
@@ -176,3 +176,15 @@ pq_dump(pq)
 void
 pq_verify(pq)
        POE::XS::Queue::Array pq
+
+# these are for testing errno is being set correctly for perl when
+# set from XS
+void
+pq__set_errno_xs(value)
+       int value
+      CODE:
+       errno = value;
+
+void
+pq__set_errno_queue(value)
+       int value

diff --git a/Changes b/Changes
index 066f66212247e567afe38ef19313f3a904a1a5f7..a102818d0f42e16affdbb55f69545c3201d0eed5 100644 (file)
--- a/Changes
+++ b/Changes
@@ -1,5 +1,10 @@
 Revision history for Perl extension POE::XS::Queue::Array.
 
+0.005 unreleased
+ - extra tests to distinguish errno problems from P::X::Q:A bugs,
+   possibly leading to a workaround
+   https://rt.cpan.org/Ticket/Display.html?id=35044
+
 0.004 Wed Apr  9 2008
  - include license information in appropriate places
  - fix @ISA, it was badly broken, thanks to Yuval Kogman (nothingmuch)

diff --git a/MANIFEST b/MANIFEST
index 4c67629be11f67c4a954c9750e1fcdb2279e1125..4e34d1d216599de1de148f5046ff6bd3a428248a 100644 (file)
--- a/MANIFEST
+++ b/MANIFEST
@@ -12,6 +12,7 @@ queue.c         Moved the implementation code here
 queue.h
 t/01_array.t
 t/02_release.t
+t/03_errno.t
 t/90_pod.t
 t/91_pod_cover.t
 typemap

diff --git a/alloc.c b/alloc.c
index d2bee611015e94e491fe748cae37f8778a2fb798..b23b3deb31a88432abdad6d856a8c9bc99ea4b62 100644 (file)
--- a/alloc.c
+++ b/alloc.c
@@ -237,15 +237,15 @@ mymalloc(size_t size) {
   void *buf;
 
   if (size < 0) {
-    fprintf(stderr, "Attempt to allocate size %d\n", size);
+    fprintf(stderr, "Attempt to allocate size %d\n", (int)size);
     exit(3);
   }
 
   if ( (buf = malloc(size)) == NULL ) {
-    mm_log((1, "mymalloc: unable to malloc %d\n", size));
-    fprintf(stderr,"Unable to malloc %d.\n", size); exit(3);
+    mm_log((1, "mymalloc: unable to malloc %d\n", (int)size));
+    fprintf(stderr,"Unable to malloc %d.\n", (int)size); exit(3);
   }
-  mm_log((1, "mymalloc(size %d) -> %p\n", size, buf));
+  mm_log((1, "mymalloc(size %d) -> %p\n", (int)size, buf));
   return buf;
 }
 

diff --git a/queue.c b/queue.c
index 9a8230f2279fd2ff1eff52a9ab83d32bc0cb886f..f56140fc2b7a7864e3fe2a67ca3dfad93de73dfc 100644 (file)
--- a/queue.c
+++ b/queue.c
@@ -830,3 +830,14 @@ pq_verify(poe_queue *pq) {
     exit(1);\r
   }\r
 }\r
+\r
+/*\r
+pq__set_errno_queue - set errno\r
+\r
+This just sets errno for testing purposes.\r
+*/\r
+void\r
+pq__set_errno_queue(int value) {\r
+  errno = value;\r
+}\r
+\r

diff --git a/queue.h b/queue.h
index 036eb9ea71a2f4ebedd7264b343a35aa0e425277..62a43286f8cc29ca8bccd5d192b2c6d881dd583b 100644 (file)
--- a/queue.h
+++ b/queue.h
@@ -37,4 +37,7 @@ pq_peek_items(poe_queue *pq, SV *filter, int max_count, pq_entry **items);
 extern void pq_dump(poe_queue *pq);\r
 extern void pq_verify(poe_queue *pq);\r
 \r
+extern void\r
+pq__set_errno_queue(int value);\r
+\r
 #endif\r