From 1a19d068476d9ed873426ad315ef9c530440f499 Mon Sep 17 00:00:00 2001
From: Tony Cook <tony@develop=help.com>
Date: Sat, 26 Mar 2005 14:18:55 +0000
Subject: [PATCH] - added samp-form.cgi and samp-image.cgi to the samples
 directory to   demonstrate displaying a generated image on a HTML page.

---
 Changes                 | 2 ++
 MANIFEST                | 2 ++
 TODO                    | 9 ++++++++-
 lib/Imager/Cookbook.pod | 4 ++++
 samples/README          | 8 ++++++++
 5 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/Changes b/Changes
index 9ecca212..0088540d 100644
--- a/Changes
+++ b/Changes
@@ -1042,6 +1042,8 @@ Revision history for Perl extension Imager.
   values across to the returned color objects.
   http://rt.cpan.org/NoAuth/Bug.html?id=11860 
 - Imager::Cookbook wasn't included in the MANIFEST
+- added samp-form.cgi and samp-image.cgi to the samples directory to 
+  demonstrate displaying a generated image on a HTML page.
 
 =================================================================
 
diff --git a/MANIFEST b/MANIFEST
index c8afe450..7c7dc827 100644
--- a/MANIFEST
+++ b/MANIFEST
@@ -105,6 +105,8 @@ rotate.c
 samples/README
 samples/anaglyph.pl
 samples/interleave.pl
+samples/samp-form.cgi
+samples/samp-image.cgi
 spot.perl	For making an ordered dither matrix from a spot function
 stackmach.c
 stackmach.h
diff --git a/TODO b/TODO
index 9fcd5d57..490f3e94 100644
--- a/TODO
+++ b/TODO
@@ -28,7 +28,7 @@ not commitments.
 - add concept index to Imager.pm pod (done, still working it)
 - replace testimg/penguin-base.ppm with a smaller image (done)
 - add a sample CGI HTML and image generation scripts that work together,
-  with appropriate security management
+  with appropriate security management (done)
 - add sample CGI that handles an uploaded image
 - examples for fountain filter in Imager::Filters
 - provide access to right-side bearing information from the bounding box
@@ -46,6 +46,13 @@ not commitments.
 - implement gsamp()/gsampf()/plin() etc methods for those low level image
   interfaces which don't yet have methods.
 - implement i_incomplete for png and gif files.
+- documentation audit, check:
+  - every method has at least one example, but if the method is complex
+    (like transform2, to_paletted, string() for example) it should include 
+    a range of examples
+  - check each method description to ensure it's reasonably clear.
+  - check POD sections (SEE ALSO in particular)
+- rework handling of antialiasing against transparent images
 
 Speculation
 -----------
diff --git a/lib/Imager/Cookbook.pod b/lib/Imager/Cookbook.pod
index e9094874..b82f6970 100644
--- a/lib/Imager/Cookbook.pod
+++ b/lib/Imager/Cookbook.pod
@@ -156,6 +156,10 @@ the values supplied to both requests.
 How you make the data available to the image generation code depends
 on your application.
 
+See C<samples/samp-form.cgi> and C<samples/samp-image.cgi> in the
+Imager distribution for one approach.  The POD in C<samp-form.cgi>
+also discusses some of the issues involved.
+
 =head2 Parsing an image posted via CGI
 
 C<WARNING>: file format attacks have become a common attack vector,
diff --git a/samples/README b/samples/README
index deaa278d..959d2e3b 100644
--- a/samples/README
+++ b/samples/README
@@ -20,3 +20,11 @@ interleave.pl
   This includes 3 different implementations, first using transform2(),
   the second using the internal i_copyto() function and the third using
   the internal i_glin() and i_plin() functions.
+
+samp-form.cgi
+samp-image.cgi
+
+  Example that demonstrates generating an image linked from a HTML form.
+
+  The POD for this sample discusses alternate approaches and security
+  considerations.
-- 
2.39.5