From: Tony Cook Date: Sun, 6 Jan 2019 04:16:01 +0000 (+1100) Subject: i_img_info() (C API) no longer tries to handle a NULL image object pointer. X-Git-Tag: v1.009~11 X-Git-Url: http://git.imager.perl.org/imager.git/commitdiff_plain/6fa51f9ca59e21ee28c9dcc124bff0189f5d6587 i_img_info() (C API) no longer tries to handle a NULL image object pointer. --- diff --git a/Changes b/Changes index b6c0f948..c06e676c 100644 --- a/Changes +++ b/Changes @@ -109,6 +109,9 @@ High severity: glyph index with a NULL character map. This should be rare. CID 185297. + - i_img_info() (C API) no longer tries to handle a NULL image object + pointer. CID 185298. + [1] The first two build submissions ended up at the end of a ~400 build queue, and seemed to have been cancelled by Coverity. A build submitted on NYE went through in minutes. diff --git a/image.c b/image.c index cdfa2ed4..bd634ee1 100644 --- a/image.c +++ b/image.c @@ -318,21 +318,15 @@ void i_img_info(i_img *im, i_img_dim *info) { dIMCTXim(im); im_log((aIMCTX,1,"i_img_info(im %p)\n",im)); - if (im != NULL) { - im_log((aIMCTX,1,"i_img_info: xsize=%" i_DF " ysize=%" i_DF " channels=%d " - "mask=%ud\n", - i_DFc(im->xsize), i_DFc(im->ysize), im->channels,im->ch_mask)); - im_log((aIMCTX,1,"i_img_info: idata=%p\n",im->idata)); - info[0] = im->xsize; - info[1] = im->ysize; - info[2] = im->channels; - info[3] = im->ch_mask; - } else { - info[0] = 0; - info[1] = 0; - info[2] = 0; - info[3] = 0; - } + + im_log((aIMCTX,1,"i_img_info: xsize=%" i_DF " ysize=%" i_DF " channels=%d " + "mask=%ud\n", + i_DFc(im->xsize), i_DFc(im->ysize), im->channels,im->ch_mask)); + im_log((aIMCTX,1,"i_img_info: idata=%p\n",im->idata)); + info[0] = im->xsize; + info[1] = im->ysize; + info[2] = im->channels; + info[3] = im->ch_mask; } /*