projects / imager.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 396eb23) | patch
modernize t/200-file/400-basic.t and handle fails correctly
authorTony Cook <tony@develop-help.com>
Tue, 26 Jan 2016 09:34:53 +0000 (20:34 +1100)
committerTony Cook <tony@develop-help.com>
Tue, 26 Jan 2016 09:34:53 +0000 (20:34 +1100)
commit5563c20371999396b8c3c46e83872087203a71eb
treeae2ab1df2573ea18a791ae99ed79c7afad5ca0batree | snapshot
parent396eb238f041bfe959fe5bbe86e97af107d2276ecommit | diff
modernize t/200-file/400-basic.t and handle fails correctly

Previously the custom ok() would mis-handle errors, because it called
methods in list context, which on failure could treat the note for the
test as the result and pass.

This typically resulted in crashes later in the code, see

  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=812093

for an example.
Makefile.PL diff | blob | blame | history
t/200-file/400-basic.t diff | blob | blame | history
Image manipulation for perl