Coverity complained colors could be left uninitialized.

[imager.git] / Changes

diff --git a/Changes b/Changes
index f6eb87be23e46f5d58e9726b4e95c8b0237ed579..bfb3c680318a6fee5eb9cbc43502a031f982a94a 100644 (file)
--- a/Changes
+++ b/Changes
@@ -10,6 +10,37 @@ Coverity finally finished a build, fix a few problems:
    space could result in memory leaks.  This can probably only be
    reproduced on very wide floating-point sample images.
 
+ - convert an array style function parameter pointer to pointer style
+   to prevent confusing Coverity in the T1 bounding box implementation.
+
+ - Similarly in the FT1 bounding box implementation.
+
+ - initialize a pointer to prevent Coverity complaining in polygon
+   drawing (it should always end up being set.)
+
+ - addi style makemap could potentially read one past the end of an
+   array.
+
+ - supplying a numeric hatch of 32 to Imager::Fill->new(hatch => ...)
+   would result in read beyond the end of the built-in hatch array.
+   Negative values (which Coverity didn't complain about) could also
+   cause problems.
+
+ - the Imager::Color set_internal() interal method no longer
+   calls the over-complicated ICL_set_internal() (which is retained
+   only for the old API.)  Coverity complained that this leaked, but
+   this could only occur with an invalid (NULL pointer) color object.
+
+ - the underlying implementation of the map() method could read before
+   the beginning on an allocated array if supplied with inconsistent
+   parameters, which Coverity complained about.  No Imager code calls
+   that function with inconsistent parameters, but a
+   belt-and-suspenders check was added.
+
+ - Coverity complained a call to i_getcolors(), used by the
+   implementation of the is_bilevel() method could leave the fetched
+   colors uninitialized.  Added a return value check.
+
 Imager 1.008 - 31 Dec 2018
 ============