release GifRow and comments memory on all error returns (revealed by

[imager.git] / Changes

Imager release history.  Older releases can be found in Changes.old

Imager 0.69 - 08 Sep 2009
===========

Bug fixes:

 - broken test fix - was attempting to call a function skip_all, when
   that should be a parameter to plan().

 - briefly document apidocs.perl, the tool used to build
   Imager::APIRef and make some minor enhancements

 - various minor documentation enhancements and fixes.

Imager 0.68 - 07 Sep 2009
===========

 - Imager->new(file => $filename) and other similar incantations will
   load the given file.
   https://rt.cpan.org/Ticket/Display.html?id=48261

Bug fixes:

 - avoid using CHECK as a label in Imager::Test
   http://nntp.x.perl.org/group/perl.cpan.testers/5220921

 - re-work most image file test files that require a library into
   separate library present/not present files to remove stupidly long
   conditionals

 - don't treat rubthrough() outside the bounds of the target image as
   an error.
   http://nntp.x.perl.org/group/perl.cpan.testers/5185716

Imager 0.67_01 - 02 Sep 2009
==============

Bug fixes:

 - correct documentation of default of raw image interleave read
   parameter
   https://rt.cpan.org/Ticket/Display.html?id=42074

 - add raw_ prefix to raw read parameters, though the original names
   still work.

 - fail the read if an invalid raw_interleave parameter is supplied

 - warn if no interleave or raw_interleave parameter is supplied,
   since the documented default was wrong, and incompatible with the
   write format

 - for reading raw images, if raw_storechannels > raw_datachannels,
   set the extra channels in the image to 0

 - when probing for executables like freetype-config, search for .bat
   and .cmd on MSWin32, as well as .exe.
   https://rt.cpan.org/Ticket/Display.html?id=49275

 - re-work the external libraries section of README:
   - list Debian and Redhat package names for each library
   - reformatting
   - update URLs

 - use the new EU::MM META_MERGE facility instead of generating
   META.yml from scratch
   https://rt.cpan.org/Ticket/Display.html?id=47888

 - use Devel::CheckLib (bundled, modified) to check which release of
   libtiff is installed and reject 3.9.0
   http://bugzilla.maptools.org/show_bug.cgi?id=2088
   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=543079

Imager 0.67 - 12 Dec 2008
===========

Bug fixes:

 - fix a packaging error

Imager 0.66 - 12 Dec 2008
===========

 - 24-bit color .ICO/.CUR files can now be read.

Bug fixes:

 - an optimization skipping 0 src alpha values could cause the
   rubthrough() to read past the end of a buffer.
   http://www.nntp.perl.org/group/perl.cpan.testers/2008/05/msg1509184.html

 - corrected a reference leak where writing GIFs would leak memory.
   This could also happen calling to_paletted().
   Also documented the underlying long existing feature where the
   colors parameter is filled with the generated color table and added
   tests for it.
   http://rt.cpan.org/Ticket/Display.html?id=41028

 - write out the image size in bytes field of a BMP correctly.
   http://rt.cpan.org/Ticket/Display.html?id=41406

 - add limited tests for Imager::ExtUtils

 - make Imager::ExtUtils->includes use an absolute path, since
   a relative path could cause failures using Inline::C.
   http://rt.cpan.org/Ticket/Display.html?id=37353

 - re-arrange the POD for Imager::Font::BBox:
   - mark total_width(), pos_width(), end_offset() obsolete, since
     they're mostly for backwards compatibility
   - group width methods and height methods
   https://rt.cpan.org/Ticket/Display.html?id=39999

Imager 0.65 - 20 May 2008
===========

Bug fixes:

 - In some cases when an error occurs reading those parts of a JPEG
   file after the image the scan-line buffer could be freed a second
   time.  In cases where the the error occured while reading the image
   data it's possible that the buffer could have leaked.
   Thanks to Gabriel Vasseur for reporting this and help in tracking
   it down.

 - the gif_screen_height tag was overriding the screen width and being
   ignored for the screen height when present.
   https://rt.cpan.org/Public/Bug/Display.html?id=35568

Imager 0.64 - 23 April 2008
===========

This is a bug fix release.  This includes a fix for a possible
security issue.

Bug fixes:

 - Possible security issue: The floating point sample path for image
   based fills had a buffer overflow.  This would overwrite the end of
   a malloc()ed buffer with double precision floats.
   http://rt.cpan.org/Ticket/Display.html?id=35324
   CVE-2008-1928

 - check that the result of fileno($fh) is defined rather than simply
   true when read() or write() is supplied with an fh parameter.
   http://rt.cpan.org/Ticket/Display.html?id=35139

 - i_scale_axis() wasn't checking the result of i_img_new_ch()
   resulting in a SIGSEGV when attempting to scale an image to a size
   too large to fit in memory.  This is a NULL pointer access issue,
   not a buffer overflow.
   Added a check for the failure.
   scale_calculate() (and hence scale()) will now fail if any of the
   scale size parameters are a reference.
   http://rt.cpan.org/Ticket/Display.html?id=35172

 - Regression: filling a greyscale image with a hatch used the wrong
   color channels from the supplied fg/bg colors.
   https://rt.cpan.org/Ticket/Display.html?id=35278

 - fixed a related problem for image fills.

Imager 0.63 - 7 April 2008
===========

This release primarily contains changes to improve ease of use -
rather than you having to convert images to the appropriate number of
channels, Imager handles it internally.  How to handle drawing colors
and the default combine mode is a thornier problem left for some other
release.

 - the font libraries are now only initialized when needed.
   http://rt.cpan.org/Ticket/Display.html?id=28825

 - moved the imtoc.perl code into Imager::Preprocess

 - paste() and rubthrough() now adapt the source image data to the
   destination, so you can now safely paste/rubthrough from greyscale
   images to color images or back, or from alpha channel images to
   noalpha channels or back.
   https://rt.cpan.org/Ticket/Display.html?id=30908

 - rubthrough() now falls back to pasting when the source doesn't have
   an alpha channel.  This effectively treats the source as having a
   max alpha channel, the right thing to do.
   http://rt.cpan.org/Ticket/Display.html?id=29944

 - re-worked most of the area filling code to use a common set of
   functions when filling.
   Corrected normal combine mode.
   Rewrote most of the combine modes to match the way the SVG draft
   defines them with respect to a translucent source and destination.
   Added tests for translucent source and destination.
   Added tests to check 8-bit/sample and double/sample combines work
   similarly.
   https://rt.cpan.org/Ticket/Display.html?id=29879

 - writing a 2 or 4 channel image to a JPEG file will now write that
   image as if composited against a background, black by default,
   overridable with the i_background tag/parameter.
   https://rt.cpan.org/Ticket/Display.html?id=29876

 - writing a 2 or 4 channel image to a PGM/PPM file will now write
   that image as if composited against a background, black by default,
   overridable with the i_background tag/parameter.
   http://rt.cpan.org/Ticket/Display.html?id=30074

 - writing a 2 or 4 channel image to a BMP file will now write that
   image as if composited against a background, black by default,
   overridable with the i_background tag/parameter.
   http://rt.cpan.org/Ticket/Display.html?id=30075

Bug fixes:

 - Imager::Matrix2d->translate() now only requires one of the x or y
   parameters.
   http://rt.cpan.org/Ticket/Display.html?id=29937

 - mixing qtype scaling now sets all channels of a pixel to zero if
   the pixel has zero coverage (zero alpha).  This should produce more
   compressible output files.
   http://rt.cpan.org/Ticket/Display.html?id=32324

 - removed the pointless #! line from lib/Imager/Font/Wrap.pm
   Noticed when I saw:
   https://bugzilla.redhat.com/show_bug.cgi?id=166254
   I'm not changing the #! lines of the sample code, since it's sample
   code, not intended for installation.
   http://rt.cpan.org/Ticket/Display.html?id=33408

 - some TGA images weren't being detected correctly as TGA images
   https://rt.cpan.org/Ticket/Display.html?id=32925

 - handling of the left-over bit for 16-bit/pixel TGA images has been
   changed to match the behaviour of the GIMP.  Previously the bit
   being set was treated as an opaque pixel, but one user reported a
   problem with loading such an image.  I haven't been able to find any
   tools beyond the GIMP that handle alpha-channel 16-bit TGAs, so
   I'll match it's behaviour.  See issue 114913 in the GIMP's
   bugzilla.
   http://rt.cpan.org/Ticket/Display.html?id=32926

Imager 0.62 - 10 December 2007
===========

 - Makefile.PL now expands ~/path supplied to --incpath or --libpath
   to /path under your home directory.
   http://rt.cpan.org/Ticket/Display.html?id=29484

 - the old dynaload code used Mach API functions to load dynamic
   libraries on Mac OS X.  These APIs have been deprecated in OS X
   10.5 and were causing some build problems.
   So henceforth Imager uses the dlopen() family of functions, and you 
   will need version 10.3 or later of OS X.

 - added the det() function to the transform2() engine.
   added the sample quad_to_square.pl
   Courtesy Richard Fairhurst.
   http://rt.cpan.org/Ticket/Display.html?id=31244

Bug fixes:

 - samples/gifscale.pl sourced the base value for gif_top from
   gif_left.
   Thanks to Eleneldil G. Arilou for pointing this out.

 - t/t82inline.t no longer loads B at runtime, to work around a bug
   in some 5.005_0[45] installations.
   http://rt.cpan.org/Ticket/Display.html?id=30508

 - work around Module::Depends::Intrusive bug #21229
   http://rt.cpan.org/Ticket/Display.html?id=30520

 - the hardinvert filter no-longer inverts the alpha channel.
   http://rt.cpan.org/Ticket/Display.html?id=30002

 - the hardinvert filter now supports large samples

Imager 0.61_02 - 28 November 2007
==============

 - major TIFF support re-work
   http://rt.cpan.org/Ticket/Display.html?id=20329

 - added a C level image interface for accessing samples from 1-32
   bits, exposed this at the perl level in getsamples()

 - the conv filter now works at floating point precision for high bit
   images

 - added is_bilevel method to test whether an image should be written as
   a bilevel image if the image format supports it.

 - added -log-stderr as an Imager import list option

 - added some important types to Imager::APIRef

 - added test_image_double() to Imager::Test

Bug fixes:

 - Imager::Fountain couldn't read GIMP gradient files with 10 or more
   segments

 - the scale() method with qtype mixing now handles images with an
   alpha channel correctly.

 - fixed a broken link from the "animated GIF" entry in the concept index.
   Thanks to Slaven Rezic.
   http://rt.cpan.org/Ticket/Display.html?id=30889

 - on some perl's the infix expression parser test would fail due to
   actions in the grammar returning false.  Made sure all actions return
   a true value.
   Thanks to Richard Fairhurst for spending a lot of time in tracking
   down this problem.
   http://rt.cpan.org/Public/Bug/Display.html?id=29562

Imager 0.61 - 5 November 2007
===========

 - added samples/gifscale.pl, which adjusts the screen size/position tags
   when scaling an animated gif
   http://rt.cpan.org/Ticket/Display.html?id=27591

Bug fixes:

 - correct handling of sz in matrix_transform() - this should allow
   perspective type transformations to work now.
   http://rt.cpan.org/Ticket/Display.html?id=29936

 - prevent a cast to integer warning on x64 builds in datatypes.c
   also fixed some other type warnings
   https://rt.cpan.org/Ticket/Display.html?id=30204

 - some sub-directory tests depended on files produced by the parent
   directory tests
   http://rt.cpan.org/Ticket/Display.html?id=30203

 - Imager::Font::Wrap doesn't correctly set savepos
   thanks to Nikita Dedik and Eleneldil G. Arilou for reporting this.
   http://rt.cpan.org/Ticket/Display.html?id=29771

 - test 171 in t/t01introvert.t was failing on perls configured to
   use long double.
   http://rt.cpan.org/Ticket/Display.html?id=29413

 - the code for the transform2() uminus operator was missing a break.
   Added tests for better code coverage of the ops.
   http://rt.cpan.org/Ticket/Display.html?id=29296

 - the SGI RLE compression code could overflow its compression buffer
   http://rt.cpan.org/Ticket/Display.html?id=30334

 - the 32-bit output function used by the SGI code only handled values
   under 0x10000.  This was most noticable when writing large RLE images.
   http://rt.cpan.org/Ticket/Display.html?id=30335

 - validate chan_count for chans == NULL for each of the i_gsamp()
   implementations.
   http://rt.cpan.org/Ticket/Display.html?id=28985

 - attempt to work around the test failure at 
   http://www.nntp.perl.org/group/perl.cpan.testers/2007/09/msg650810.html
   http://rt.cpan.org/Ticket/Display.html?id=29562

 - improve the error messages produced when attempting to read or write
   an unknown image file format.
   http://rt.cpan.org/Ticket/Display.html?id=30103

 - improve the transform2() documentation
   http://rt.cpan.org/Ticket/Display.html?id=29267

 - correctly generate the author key in META.yml
   http://rt.cpan.org/Ticket/Display.html?id=30377

 - correctly blend a rotated (or matrix_transformed()) image when
   performing interpolation in the presence of an alpha channel.
   Also corrected the centring of the rotated image on the output
   image.

Imager 0.60 - 30 August 2007
===========

 - Finished/rewrote Arnar's old SGI RGB file format support, so Imager
   now has full SGI RGB image format, including RLE and 16-bit/sample
   images.
   https://rt.cpan.org/Ticket/Display.html?id=8666

 - logging functions are now available in the API

 - applied Gabriel Vasseur's patch
   added documentation, further tests, and support for greyscale images
   Obviously problems are my fault :)
   https://rt.cpan.org/Ticket/Display.html?id=28142

 - the mask for ICO/CUR images is now applied as an alpha channel to
   the returned image.  For the old behaviour, supply ico_masked => 0
   to read() or read_multi().  This should be less confusing when
   using Imager as a general image processor.
   https://rt.cpan.org/Ticket/Display.html?id=29001

Bug fixes:

 - in some cases it's possible for giflib/libungif to return color 
   indexes outside the range of colors defined by the image's palette.
   We now expand the palette to match the indexes used.
   Thanks to Gabriel Vasseur for reporting this.

 - fixed various memory leaks that could occur when failing to read png,
   jpeg, bmp or tga files.

 - to avoid confusion, channels not present in the image are returned as
   zero by getscanline().  This has no effect on the C level i_glin()
   and i_glinf() API functions which continue to not set the unused
   channels.

 - the convert() method now returns an image of the same sample size as
   the source image.
   https://rt.cpan.org/Ticket/Display.html?id=28492

 - remove repeated text in Imager::Files
   http://rt.cpan.org/Ticket/Display.html?id=27589

 - be even more explicit that scale() and friends don't modify the source
   image, but return a new image.
   http://rt.cpan.org/Ticket/Display.html?id=28570

 - improve the error message from errstr() when you try to load a font
   for which the driver hasn't been built in Imager.
   http://rt.cpan.org/Ticket/Display.html?id=27571

 - transparency is now enabled by default when writing GIF images
   http://rt.cpan.org/Ticket/Display.html?id=27615

 - Imager would not load on Windows 98
   http://rt.cpan.org/Ticket/Display.html?id=27653

Imager 0.59 - 14 June 2007
===========

Bug fixes:

 - fixes a regression introduced by the fixes for RT 11972
   http://rt.cpan.org/Ticket/Display.html?id=27546

 - cropping outside the image would return an Imager object with
   no low-level image object, instead of returning false.
   Fixed by: Philip Gwyn (Leolo)
   http://rt.cpan.org/Ticket/Display.html?id=27509

Imager 0.58 - 16 May 2007
===========

No significant changes from 0.57_01.

Imager 0.57_01 - 11 May 2007
==============

 - added to_rgb16 to produce a 16-bit/sample version of an image

 - improve freetype 1.x text output efficiency

Bug fixes:

 - search another place for rgb.txt, and check all the places 
   Imager::Color checks when deciding whether to skip testing it
   http://rt.cpan.org/Ticket/Display.html?id=26064

 - use a convolution kernel size based on the stddev rather than a
   fixed size when performing a gaussian blur
   http://rt.cpan.org/Ticket/Display.html?id=25645

 - document the difference() method's mindist parameter, and debug it.

 - put the Imager release number in the Inline::C generated code to
   regenerate Inline code when a new release of Imager is installed.
   http://rt.cpan.org/Ticket/Display.html?id=26278

 - fix rendering on alpha channel images for the FreeType 1.x driver.
   http://rt.cpan.org/Ticket/Display.html?id=11972

 - fix rendering on alpha channel images for the T1lib driver.
   http://rt.cpan.org/Ticket/Display.html?id=11972

 - reworked library probing, we can now set more than one probe
   function for a library.  Disabled the default (non-freetype-config)
   library probe and added an extra probe function that searches for
   both ft2build.h and whatever it includes, and adds -I as needed.
   Hopefully this will fix build problems like
   http://www.nntp.perl.org/group/perl.cpan.testers/2007/05/msg472281.html
   http://rt.cpan.org/Ticket/Display.html?id=26086

Imager 0.57 - 30 Apr 2007
===========

This is a maintenence release fixing a security issue in Imager.

 - CRITICAL: a specially crafted compressed BMP file can cause a buffer
   overflow in malloced memory.  There will be further discussion of
   this issue in the ticket below.
   http://rt.cpan.org/Ticket/Display.html?id=26811
   CVE-2007-2459  CVE-2007-2413
   The descriptions at cve.mitre.org varied in quality, please see the
   ticket at rt.cpan.org for a more accurate description of the issue.

Imager 0.56 - 1 Apr 2007
===========

 - added support for reading 16-bit/sample PGM/PPM images

 - added support for writing 16-bit/sample PGM/PPM images

 - improved performance of reading PBM/PGM/PPM images

 - added support for writing PBM images if the image is paletted and
   contains only black and white

 - added a new make_colors value - "mono"

 - switched from the svn log Changes to a manual Changes to reduce
   noise

 - new sample code - samples/flasher.pl

Bug fixes:

 - CRITICAL: the "Imager" typemap entry (not used by Imager itself)
   was returning an image object with an extra reference, this
   resulted in a memory leak.
   http://rt.cpan.org/Ticket/Display.html?id=24992

 - fix rendering on alpha channel images for the FreeType 2.x driver
   http://rt.cpan.org/Ticket/Display.html?id=11972

 - reading bmp files now consitently handles short reads.  You can now
   supply a parameter to treat a short read as successful and set
   i_incomplete
   http://rt.cpan.org/Ticket/Display.html?id=8426

 - previously, reading ASCII PBM files required spaces between samples,
   even though the format doesn't require that

 - improved documentation of the unsharpmask filter (I hope)
   http://rt.cpan.org/Ticket/Display.html?id=25531

 - force flushing of the output from i_tt_dump_names() and test output
   in t/t35ttfont.t to prevent output from being mixed up.
   https://rt.cpan.org/Ticket/Display.html?id=24859

 - rewrite a conditional expression as an if() to hopefully work around
   a bug in the pre-4.0 GCC Apple shipped with OS X 10.4.
   https://rt.cpan.org/Ticket/Display.html?id=25561

 - avoid Data::Dumper in regops.perl to support older releases of perl
   https://rt.cpan.org/Ticket/Display.html?id=24391

Imager 0.55 - 16 Dec 2006
===========

This is primarily a bug fix release.

Note: Test::More is now a pre-requisite for Imager and is no longer bundled.

There is one new feature:

 - the Win32 font driver now supports UTF8 (RT 22166)
   http://www.cpanforum.com/threads/3276
   http://rt.cpan.org/Ticket/Display.html?id=22166

Several bugs were fixed:

 - the string() method would not output the string "0"
   http://rt.cpan.org/Public/Bug/Display.html?id=21770

 - fills.c was failing to compile on Solaris 10 (compiler unknown)
   http://rt.cpan.org/Public/Bug/Display.html?id=21944

 - the gif_disposal and gif_user_input tags weren't being read from
   the file correctly
   http://rt.cpan.org/Public/Bug/Display.html?id=22192

 - gif.c was failing to build under MSVC
   http://rt.cpan.org/Ticket/Display.html?id=23922

 - in some cases strings passed to the string() method were treated as
   terminated by NUL (chr 0)
   http://rt.cpan.org/Public/Bug/Display.html?id=21770

 - on "MSWin32" perl builds we now link to -lzlib instead of -lz since
   that's the default build name for zlib on Win32.
   http://rt.cpan.org/Ticket/Display.html?id=23064

 - search $Config{incpath} for headers too, which we should have been
   doing all along.

Win32 font driver fixes:

 - the global descent value from bounding box was the wrong sign
   http://www.cpanforum.com/threads/3276

 - if the first or last glyph overflowed the left or right side of the
   advance width they would be clipped


Imager 0.54 - 14 Sep 2006
===========

This is primarily a feature release:

 - a new qtype value 'mixing' has been added to the scale()
   method. This is faster than 'normal', slower than 'preview'. This
   is based on the method used by pnmscale, and seems to produce less
   blurry results than normal.
   http://rt.cpan.org/Public/Bug/Display.html?id=20677

 - the rubthrough() method can now render onto images with an alpha
   channel.
   http://rt.cpan.org/Ticket/Display.html?id=20678

 - the read_multi() method now falls back to calling doing a single
   image read via the read() method and write_multi() will now fall
   back to calling write() if a single image is supplied. This means
   you can simply call the read_multi() or write_multi() functions
   without having to check if the type is formatted by that method.
   http://rt.cpan.org/Ticket/Display.html?id=19457
   http://rt.cpan.org/Ticket/Display.html?id=19458

 - the GIF loop extension can now be written. If you don't have
   libungif/giflib 4.1.4 (or some distribution's bugfixed equivalent) you
   should upgrade.
   http://rt.cpan.org/Ticket/Display.html?id=21185

 - getscanline() and setscanline() can now read/write palette index
   based data from/to the image for paletted images, by setting type to
   'index'.
   http://rt.cpan.org/Ticket/Display.html?id=20338

 - we no longer hassle you to disable GIF support
   http://rt.cpan.org/Ticket/Display.html?id=20687

 - minor documentation fixes


Imager 0.53 - 26 Jul 2006
===========

This is a bugfix release.

Some test code was left in a code path not covered by the test
suite. A test was added to cover this code path and the test code was
removed.
http://rt.cpan.org/Public/Bug/Display.html?id=20705


Imager 0.52 - 25 Jul 2006
===========

This is primarily a feature release, but contains a fair few bug
fixes, new features:

 - ability to read and write MS Windows ICO and CUR files

 - you can now add file format plugins to support new file formats

 - add POD coverage tests

 - setcolors() and addcolors() now accept color names and so on
   instead of requiring Imager::Color objects.
   http://rt.cpan.org/Ticket/Display.html?id=20056

 - flood_fill() can now fill to a specified border color instead of
   just to the area the same color as the seed.
   http://rt.cpan.org/Ticket/Display.html?id=19618


Bug fixes:

 - bounding_box for the T1 driver wasn't converting UTF8 to ascii when
   calculating the advance width.
   http://rt.cpan.org/Public/Bug/Display.html?id=20554

 - bounding_box for the T1 driver wasn't including leading and
   trailing spaces in the bounding box as the other drivers did, it also
   produced strange results for empty strings or strings containing only
   spaces

 - when reading CMYK jpeg images they were being transferred to the
   image object as is, producing a four channel image. It only looked ok
   due to an old still unfixed Photoshop bug. We now convert from the
   inverted CMYK that photoshop (and Corel for example) produce into RGB.
   http://rt.cpan.org/Ticket/Display.html?id=20416

 - reading a CYMK TIFF would result in a 4 channel image, reading any
   image with more than 4 channels (eg. RGB with 2 alpha channels) would
   result in an error.
   http://rt.cpan.org/Ticket/Display.html?id=20415

 - added /usr/local/include to the default include search path, since
   we were already searching /usr/local/lib for libraries.

And various minor fixes and documentation updates.


Imager 0.51 - 23 Apr 2006
===========

 - fix a validation bug when processing JPEG EXIF data that can cause
   a crash
   http://rt.cpan.org/Public/Bug/Display.html?id=18496

 - fix mis-processing of the src_maxx and src_maxy parameters of the
   paste() method
   http://rt.cpan.org/Public/Bug/Display.html?id=18712

 - fix a problem in Imager's "smart" handling of the color parameter
   to various methods.
   http://rt.cpan.org/Public/Bug/Display.html?id=18561


Imager 0.50 - 29 Mar 2006
===========

 - CRITICAL: fixes a segmentation fault from attempting to write a 2
   or 4 channel image to jpeg or a 2 channel image to tga where the
   output is an in-memeory buffer.
   http://rt.cpan.org/Public/Bug/Display.html?id=18397

 - fixes an incorrect pointer parameter in the PNG code
   http://rt.cpan.org/Public/Bug/Display.html?id=18051

 - skip Inline::C tests when building in a directory with spaces
   http://rt.cpan.org/Public/Bug/Display.html?id=18049